Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 7 Icons (including 3 updates) + 1 ComponentInfo #922

Merged
merged 20 commits into from
Jul 30, 2024

Conversation

eeelbrens
Copy link
Contributor

@eeelbrens eeelbrens commented Jul 30, 2024

Added:

  • Quickify
  • Spreeder
  • Speed Reader
  • Spritz

Updated:

  • Brilliant
  • Notesnook
  • You.com (also has the new CompInfo)

also, an important question:
I haven't contributed new icons in 2 months and saw your new documentation change and reshuffling. For the updates I still use my very own method of overwriting the icons then adding the alts to resources/utilities/icons (or contribs/icons for the sake of the docs change), which has the advantage of zero commits in drawable.xml files. Is this still a valid solution, which I see absolutely no issues with, given how the app and its files are structured? Can this method be added to the documentation as a quick (alt of course) method for updating apps with "less contributor-side errors"?

@flameshikari
Copy link
Member

flameshikari commented Jul 30, 2024

Hm, actually a nice idea, but there are some side effects: old icons (alts) will be in the 'New' category section but new ones won't.

I got an idea based on your suggestion: I can add additional parameters for entries in icons.yml, for example something like this:

max_stream:
  old_to_alt: true
  category: M
  compinfos:
    - com.wbd.stream/com.wbd.fuse.appcore.FuseActivity

It will be useful for manipulating specific icons (like Google apps) and cases like yours. Sure I will implement it, however I need some time to think about side effects, then some time to code and document it. For now, do it in the old way, please.

And yeah, it will be backwards compatible. I mean, you'll still can do this:

max_stream:
  - com.wbd.stream/com.wbd.fuse.appcore.FuseActivity

...if you don't need to manipulate with the icon like in the first example.

@eeelbrens
Copy link
Contributor Author

eeelbrens commented Jul 30, 2024

@flameshikari All done! Looking forward to your implementation!

@eeelbrens eeelbrens changed the title Added 7 Icons (including 3 updates) Added 7 Icons (including 3 updates) + 1 ComponentInfo Jul 30, 2024
@flameshikari
Copy link
Member

Will do my best!

@flameshikari flameshikari added this to the 1.9.4 milestone Jul 30, 2024
@flameshikari flameshikari merged commit ddbdaa1 into Delta-Icons:master Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants