Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new icons and 1 new componentinfo #930

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

davidjosefson
Copy link
Contributor

No description provided.

@flameshikari
Copy link
Member

Hello! There are some issues with your icons:

  • bank_id_alt_1: square template is deformed

image

image

Some tips to improve icons:

  • bank_id_alt_1: remove the text to make the icon more simpler, the logo still makes the icon recognizable
  • lansforsakringar: adapt the icon to the square template (it will be kind of free-form icon) and change blue color to Dark pastel blue #728DBE

image

@davidjosefson
Copy link
Contributor Author

Awesome feedback! This is my first time doing anything with svgs and InkScape, still learning :)

bank_id:

  • fixed the deformed square
  • removed the text

lansforsakringar:

  • changed blue and red colors
  • removed all unnecessary anchors and made straight lines
  • I didn't change it to a free-form square icon, since I think this icon and its colors need a white background to be usable

@flameshikari
Copy link
Member

Thanks for fixes! And welcome aboard!

I've made some fixes before merging. Keep the icon position in the center (lansforsakringar was shifted a little). And sometimes the icon size becomes float (176px -> 176.01px), maybe due export misconfiguration or accidental resizing. This isn't critical, but it can result in blurry edges on your PNG, so keep that in mind.

@flameshikari flameshikari merged commit 41d47c7 into Delta-Icons:master Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants