Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create connection pools for upgrades #2232

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Do not create connection pools for upgrades #2232

merged 1 commit into from
Dec 11, 2022

Commits on Dec 4, 2022

  1. Do not create connection pools for upgrades 

    By creating a temporary PMF based on the same properties as the `PersistenceFactoryInitializer`, the `UpgradeInitializer` would create *two* connection pools of `10` (per default) connections each, for the duration of its execution.

Because upgrades are executed in serial, connection pooling is not beneficial. Creating temporary connection pools is a wasteful operation and should be avoided.

Partially addresses DependencyTrack#1935

Signed-off-by: nscuro <nscuro@protonmail.com>
    @nscuro
    nscuro committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    3536ad7 View commit details
    Browse the repository at this point in the history