Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search component by group #3761

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

rcsilva83
Copy link
Contributor

Description

On the "Components" tab, search components also by group. Today it only searches by name but some components use generic names and differentiate themselves by group. For example, @angular/corehas group @angular and name core, so searching for "angular" I don't get all the Angular packages on the results.

Addressed Issue

Closes #3749

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Obs: Couldn't find any documentation about component search

Signed-off-by: Rodrigo Carvalho Silva <me@rodsilva.com>
Signed-off-by: Rodrigo Carvalho Silva <me@rodsilva.com>
@rcsilva83 rcsilva83 mentioned this pull request May 27, 2024
5 tasks
@nscuro nscuro added the enhancement New feature or request label May 27, 2024
@nscuro nscuro added this to the 4.12 milestone May 27, 2024
Signed-off-by: Rodrigo Carvalho Silva <me@rodsilva.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f08a24d) 21669 16422 75.79%
Head commit (f894e8f) 21669 (+0) 16426 (+4) 75.80% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3761) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 7a27645 into DependencyTrack:master May 27, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search on group field
2 participants