Backport: Fix BOM validation failing when URL contains encoded [ and ] characters
#3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters Fixes DependencyTrack#3831 Signed-off-by: nscuro <nscuro@protonmail.com>
`xerces` does not support the `http://javax.xml.XMLConstants/property/accessExternalDTD` property that `cyclonedx-core-java` is using: ``` java.lang.IllegalArgumentException: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. at org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.setAttribute(Unknown Source) at org.cyclonedx.parsers.XmlParser.createSecureDocument(XmlParser.java:339) at org.cyclonedx.parsers.XmlParser.extractAllNamespaceDeclarations(XmlParser.java:310) at org.cyclonedx.parsers.XmlParser.identifySchemaVersion(XmlParser.java:296) at org.cyclonedx.parsers.XmlParser.parse(XmlParser.java:97) ``` The remaining code relying on `xerces` turned out to be unused, and was consequently removed as well. Signed-off-by: nscuro <nscuro@protonmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
2 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Jun 24, 2024
…acters Also drop dependency on outdated `xercesImpl`. `xercesImpl` does not support the `http://javax.xml.XMLConstants/property/accessExternalDTD` property that `cyclonedx-core-java` is using: ``` java.lang.IllegalArgumentException: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. at org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.setAttribute(Unknown Source) at org.cyclonedx.parsers.XmlParser.createSecureDocument(XmlParser.java:339) at org.cyclonedx.parsers.XmlParser.extractAllNamespaceDeclarations(XmlParser.java:310) at org.cyclonedx.parsers.XmlParser.identifySchemaVersion(XmlParser.java:296) at org.cyclonedx.parsers.XmlParser.parse(XmlParser.java:97) ``` ~The remaining code relying on `xerces` turned out to be unused, and was consequently removed as well.~ Code depending on `xercesImpl` was removed already. Ports DependencyTrack/dependency-track#3866 from Dependency-Track v4.11.4. Signed-off-by: nscuro <nscuro@protonmail.com>
2 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Jun 24, 2024
…acters Also drop dependency on outdated `xercesImpl`. `xercesImpl` does not support the `http://javax.xml.XMLConstants/property/accessExternalDTD` property that `cyclonedx-core-java` is using: ``` java.lang.IllegalArgumentException: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. at org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.setAttribute(Unknown Source) at org.cyclonedx.parsers.XmlParser.createSecureDocument(XmlParser.java:339) at org.cyclonedx.parsers.XmlParser.extractAllNamespaceDeclarations(XmlParser.java:310) at org.cyclonedx.parsers.XmlParser.identifySchemaVersion(XmlParser.java:296) at org.cyclonedx.parsers.XmlParser.parse(XmlParser.java:97) ``` ~The remaining code relying on `xerces` turned out to be unused, and was consequently removed as well.~ Code depending on `xercesImpl` was removed already. Ports DependencyTrack/dependency-track#3866 from Dependency-Track v4.11.4. Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Jun 24, 2024
…acters Also drop dependency on outdated `xercesImpl`. `xercesImpl` does not support the `http://javax.xml.XMLConstants/property/accessExternalDTD` property that `cyclonedx-core-java` is using: ``` java.lang.IllegalArgumentException: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. at org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.setAttribute(Unknown Source) at org.cyclonedx.parsers.XmlParser.createSecureDocument(XmlParser.java:339) at org.cyclonedx.parsers.XmlParser.extractAllNamespaceDeclarations(XmlParser.java:310) at org.cyclonedx.parsers.XmlParser.identifySchemaVersion(XmlParser.java:296) at org.cyclonedx.parsers.XmlParser.parse(XmlParser.java:97) ``` ~The remaining code relying on `xerces` turned out to be unused, and was consequently removed as well.~ Code depending on `xercesImpl` was removed already. Ports DependencyTrack/dependency-track#3866 from Dependency-Track v4.11.4. Signed-off-by: nscuro <nscuro@protonmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes BOM validation failing when URL contains encoded
[and]characters.Addressed Issue
Fixes #3831
Backports #3865
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly