Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST endpoints to tag and untag policies in bulk #3924

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jul 6, 2024

Description

Adds the new endpoints:

  • POST /api/v1/tag/{name}/policy
  • DELETE /api/v1/tag/{name}/policy

And deprecates the redundant endpoints:

  • POST /api/v1/policy/{uuid}/tag/{name}
  • DELETE /api/v1/policy/{uuid}/tag/{name}

Addressed Issue

Relates to #586

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Adds the new endpoints:

* `POST /api/v1/tag/{name}/policy`
* `DELETE /api/v1/tag/{name}/policy`

And deprecates the redundant endpoints:

* `POST /api/v1/policy/{uuid}/tag/{name}`
* `DELETE /api/v1/policy/{uuid}/tag/{name}`

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the enhancement New feature or request label Jul 6, 2024
@nscuro nscuro added this to the 4.12 milestone Jul 6, 2024
nscuro added a commit to nscuro/dependency-track-frontend that referenced this pull request Jul 6, 2024
Replaces usages of `/api/v1/policy/{uuid}/tag/{name}` endpoints with `/api/v1/tag/{name}/policy`, in accordance with DependencyTrack/dependency-track#3924.

Also fixes redundant toasts when removing or adding tags from/to policies.

Signed-off-by: nscuro <nscuro@protonmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% (target: -1.00%) 96.43% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d25e48d) 22076 16817 76.18%
Head commit (a0ecb00) 22132 (+56) 16871 (+54) 76.23% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3924) 56 54 96.43%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 68b8e95 into DependencyTrack:master Jul 6, 2024
11 checks passed
@nscuro nscuro deleted the tag-untag-policies branch July 6, 2024 18:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant