Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation error when XML BOM declares multiple namespaces #4020

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

philippn
Copy link
Contributor

Description

This PR contains a bugfix for gh-4008. I have also added a testcase, which was created by copying the bom-1.xml from another testcase.

Addressed Issue

The commit fixes a validation error that occurs when multiple namespace declarations are present in the BOM (in the wrong order).

Additional Details

n/a

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: Philipp Nanz <philippn@gmail.com>
@nscuro nscuro added the defect Something isn't working label Jul 31, 2024
@nscuro nscuro added this to the 4.12 milestone Jul 31, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(The test failures are unrelated to your change)

@nscuro nscuro merged commit bba98bb into DependencyTrack:master Jul 31, 2024
8 of 9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants