Improve focusing on components in dependency graph #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If focusing on a dependency, the graph is now built from a dataset of de-duplicated components, drastically reducing the amount of data needed for the pre-expanded graph. Signed-off-by: RBickert <rbt@mm-software.com>
2 tasks
Signed-off-by: RBickert <rbt@mm-software.com>
nscuro
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvement to #336.
Focusing on a component in the dependency graph can result in huge amounts of data being sent from the backend to pre-expand a graph, because in big nested graphs the same components can appear multiple times and the current approach of focusing on components includes every duplicate component in its response.
With this PR, the needed components for pre-expanding a graph are being de-duplicated before being sent as a response to the frontend, resulting in a huge reduction of sent data (e.g. ~50MB => ~60KB).
Addressed Issue
Backend: #1997
Additional Details
Backend PR
Checklist
- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly