Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Support inclusion/exclusion of projects from BOM validation with tags #914

Merged

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Sep 18, 2024

Description

Supports the inclusion or exclusion of projects from BOM validation, using tags.

  • Removes the artifact:bom.validation.enabled config property

  • Adds the new artifact:bom.validation.mode config property

    • Valid options are ENABLED, DISABLED, ENABLED_FOR_TAGS, DISABLED_FOR_TAGS
    • Existing artifact:bom.validation.enabled configs are migrated to their artifact:bom.validation.mode counterpart
  • Adds the new artifact:bom.validation.tags.exclusive and artifact:bom.validation.tags.inclusive config properties to support the new ENABLED_FOR_TAGS and DISABLED_FOR_TAGS modes

Addressed Issue

Port change DependencyTrack/hyades#1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-Authored-By: Niklas <nscuro@protonmail.com>
@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base enhancement New feature or request labels Sep 18, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Sep 18, 2024
Copy link

codacy-production bot commented Sep 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.11% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (37351e4) 21349 17575 82.32%
Head commit (cdcdac4) 21412 (+63) 17650 (+75) 82.43% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#914) 68 68 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR had a database migration that is missing here. The migration sets the bom.validation.mode property based on the existing bom.validation.enabled value, and deletes the latter afterwards.

I think we can skip the first part since Hyades is not yet GA, but at the very least we should delete the old property.

@nscuro nscuro merged commit 87903c3 into main Sep 19, 2024
8 checks passed
@nscuro nscuro deleted the port-nclusion/exclusion-of-projects-from-BOM-validation-with-tags branch September 19, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants