Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to svg-to-vue-component #19

Closed
1 task done
manniL opened this issue Nov 8, 2018 · 2 comments
Closed
1 task done

Switch to svg-to-vue-component #19

manniL opened this issue Nov 8, 2018 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@manniL
Copy link
Member

manniL commented Nov 8, 2018 •
edited
Loading

Currently considering to switch https://github.com/egoist/svg-to-vue-component instead of vue-svg-loader as the former supports hot-reload 🤔
@manniL manniL added enhancement New feature or request question Further information is requested labels Nov 8, 2018
@patrickcate
Copy link

The latter only supports class and style attributes on the generated component while we support all DOM props and events.

This is a huge plus of svg-to-vue-component as well

@manniL
Copy link
Member Author

manniL commented Nov 12, 2018

@patrickcate Agreed!

wagerfield added a commit to wagerfield/nuxt-svg-loader that referenced this issue Jan 9, 2019
@wagerfield
feat: replaced vue-svg-loader with svg-to-vue-component (Developmint#19)
0c0d45b
@wagerfield wagerfield mentioned this issue Jan 9, 2019
Merged
@manniL manniL closed this as completed in #27 Jan 9, 2019
manniL pushed a commit that referenced this issue Jan 9, 2019
@wagerfield @manniL
feat: replaced vue-svg-loader with svg-to-vue-component (#19)
6061109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manniL @patrickcate