This repository has been archived by the owner on Sep 26, 2022. It is now read-only.
Support generic headers and HTTP timeouts #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsimps2
force-pushed
the
add-http-headers
branch
3 times, most recently
from
ede9144
to
040368e
Compare
|
@mcsimps2 We may have hit nedbat/coveragepy#883 Trying a fix in #228 |
|
@mcsimps2 Fixed on master. Please rebase. |
mcsimps2
force-pushed
the
add-http-headers
branch
from
040368e
to
9e1ed1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 86.72% 86.86% +0.13%
==========================================
Files 23 23
Lines 2335 2344 +9
==========================================
+ Hits 2025 2036 +11
+ Misses 310 308 -2
Continue to review full report at Codecov.
|
mcsimps2
force-pushed
the
add-http-headers
branch
from
9e1ed1b
to
db6be11
Compare
Instead of solely urllib3 header support, there is now the ability to pass generic headers such as "Authorization" in addition to the urllib3 headers (e.g. "basic_auth"). Furthermore, http timeouts are honored in the FileDownloader.
mcsimps2
force-pushed
the
add-http-headers
branch
from
db6be11
to
d0e29f4
Compare
|
Okay, the PR is ready for review now, with an added test on the headers - let me know what changes need to be made |
|
@mcsimps2 Hey! Sorry for the delayed reply. Please remove the Py2 support. |
mcsimps2
added a commit
to mcsimps2/PyUpdater
that referenced
this pull request
Jan 20, 2020
The current headers logic uses inspect for argument inspection, and since the behavior differs between Py3 and Py2, the six package was being used. Since we no longer support Py2, this commit removes the corresponding statements for Digital-Sapphire#226
|
My apologies, I'm a little behind on everything! I've removed support here: #232 |
|
@mcsimps2 No worries. I appreciate the help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of solely
urllib3.utils.make_headerscompatible headers, there is now the ability to pass generic headers, such as "Authorization." For example, the following is now valid headers argument when creating aClient:Furthermore, http timeouts are honored in the FileDownloader.
Fixes #218 and implements #219.