fix(watcher): remove default signal watch, use ctx (#49)

DoNewsCode · Feb 23, 2021 · 3cd7b7b · 3cd7b7b
1 parent b13eb0b
commit 3cd7b7b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/config/config.go b/config/config.go
@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"github.com/DoNewsCode/core/config/watcher"
 	"reflect"
 
 	"github.com/DoNewsCode/core/contract"
@@ -85,7 +84,8 @@ func (k KoanfAdapter) Reload() error {
 // in the run group.
 func (k KoanfAdapter) Watch(ctx context.Context) error {
 	if k.watcher == nil {
-		k.watcher = watcher.Signal{}
+		<-ctx.Done()
+		return ctx.Err()
 	}
 	return k.watcher.Watch(ctx, k.Reload)
 }

diff --git a/config/watcher/signal.go b/config/watcher/signal.go
@@ -1,3 +1,5 @@
+//+build !windows
+
 package watcher
 
 import (

diff --git a/config/watcher/singal_test.go b/config/watcher/singal_test.go
@@ -1,3 +1,5 @@
+// +build !windows
+
 package watcher
 
 import (