Consume changes to ImageReference making the alt property optional
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helje5
reviewed
Jun 7, 2024
| @@ -173,7 +173,7 @@ extension DocCArchive.ImageReference { | |||
| var ms = "<picture><source\(media) srcset='\(srcset)'>" | |||
|
|
|||
| ms += "<img" | |||
| if !alt.isEmpty { ms += " alt='\(alt.htmlEscaped)'" } | |||
| if alt?.isEmpty == false { ms += " alt='\(alt!.htmlEscaped)'" } | |||
There was a problem hiding this comment.
Can we do an if let alt = alt, !alt.isEmpty { here?
There was a problem hiding this comment.
Yep, happy to make that change!
There was a problem hiding this comment.
This is done. I did something similar to match in the other pull request.
DavidBrunow
force-pushed
the
update/optionalAlt
branch
from
c18a422
to
b25c6c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume changes to the alt text being optional.