Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix No such file or directory on conda activate #1769

Closed
wants to merge 66 commits into from
Closed

Fix No such file or directory on conda activate #1769

wants to merge 66 commits into from

Conversation

mokeyish
Copy link
Contributor

For issue microsoft#15818

Kartik Raj and others added 30 commits March 17, 2022 18:09
…s (#18661)

* Revert "Use conda run for conda environments for running python files (#18520)"

This reverts commit 8fc8648.

* Revert "Fix unit tests related to terminal code execution (#18549)"

This reverts commit c5e5979.

* News entry
Bumps [wrapt](https://github.com/GrahamDumpleton/wrapt) from 1.12.1 to 1.14.0.
- [Release notes](https://github.com/GrahamDumpleton/wrapt/releases)
- [Changelog](https://github.com/GrahamDumpleton/wrapt/blob/develop/docs/changes.rst)
- [Commits](GrahamDumpleton/wrapt@1.12.1...1.14.0)

---
updated-dependencies:
- dependency-name: wrapt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… a python interpreter (#18427)

* Support conda environments without a python executable

* Fix interpreter display

* Fix areSameEnv

* Add support to select env folders as interpreterPaths

* Allow selecting such environments

* Handle resolving environment path

* Document resolver works for both env path and executable

* Fxi bug

* Simplify conda.ts

* Define identifiers for an environment

* Fix getCondaEnvironment

* Introduce an id property to environments

* Update proposed discovery API to handle environments

* Fix bug with interpreter display

* Normalize path passed in resolveEnv

* Update environment details API

* Dont use pythonPath for getting active interpreter for activation commands

* Support conda activation

* Support ${command:python.interpreterPath} with this envs

* Fix getActiveItem

* Add comment justifying using `.pythonPath` for middleware

* Fix shebang codelens

* Fix startup telemetry

* Do not support pip installer for such environments

* Trigger discovery once installation is finished for such environments

* Automatically install python into environment once it is selected

* Add telemetry for new interpreters discovered

* Add telemtry if such an env is selected

* Fix bugs and cache installer

* Fix compile errors, tests, and add tests

* Fix some tests

* Ignore id when comparing envs

* Phew, fixed terrible tests in module installer

* Fix more tests

* MOre

* Skip resolver tests on linux

* Fix tests

* If environment doesn't contain python do not support pip installer

* Skip module install tests for python as it is not a module

* News entry

* Remove unnecssary commnet

* Fix bug introduced by merges

* Code reviews
* Improve discovery resolving API

* Improve public api doc

* Fix tests
* Fallback to conda if we don't find conda in env

* Fix tests
* Changes to conda paths not detected

* oops
* Trim the contents of pipenv dot project file after reading it

* Update tests
… activation using shell scripts (#18748)

* Use `conda run` to get the activated environment variables instead of activation using shell scripts

* news

* Have larger timeout for conda

* Doc comment

* Fix tests
…ails if it already has latest info (#18766)
* Execute conda related commands using shell

* Fix resolve utils unit tests

* Oops
* Run conda related installation commands using shell

* Update tests
…8773)

* Display env folder path in interpreter display for environments lacking an interpreter

* Fix tests

* Ensure we set display accordingly for envs lacking an interpreter

* Fix unit tests
* Prefer to use .bat files over .exe for conda on windows

* Only build VSIX

* Oops

* Fix

* Run all tests

* Add tests
* Update npm packages
* Update version
* Update change log
* Update TPN
* Fix sendCancellation

* Upgrade vscode-jupyter-lsp-middleware

* Update to latest LSP packages

* Update vscode.proposed.notebookEditor.d.ts

* Remove proposed api d.ts files that are no longer listed in package.json

* Update mocks

* Upgrade to @types/vscode 1.65.0

* Generate package-lock.json with NPM 8.5.2

* Upgrade to vscode-jupyter-lsp-middleware 0.2.40 to try to fix vscode-dts issue

* Upgrade to vscode-jupyter-lsp-middleware 0.2.41 to try to fix vscode-dts issue

* Back up to previous dot release of LSP which was dependent on VSC 1.63.0 instead of 1.66.0

* Add mocks to fix unit tests

* Remove vscode-dts devDependency; no longer needed with middleware change

* Upgrade webpack to fix Create VSIX error

* Switch to latest webpack 4 and upgrade plugins

* Reupgrade webpack to 5.x; upgrade ts-loader, copy-webpack-plugin

* Add webpack resolve fallback to path-browserify

* locators/index.ts -> wrappers.ts (webpack issues)

Co-authored-by: Kim-Adeline Miguel <kimiguel@microsoft.com>
kimadeline and others added 29 commits March 31, 2022 07:57
* Update packages from npm outdated

* Inversify 5.0.5

* Fix linting issues

* Revert inversify and prettier changes
* Add odd number definition for insiders versions

* Add comment
* Update fs-extra, chai, download, get-port, sinon
* Update glob, mocha
* Update untildify, uuid
* Update vscode/test-electron
* Update del, expose-loader, flat
* Remove lolex
* Remove gulp utilities + upgrade iconv-lite
* Update jsonc-parser, mocha-junit-reporter
* sudo-prompt, uint64be, unicode, ts-node
* Upgrade webpack cli
* Upgrade minimatch
…nd, resolve it as unknown (#18856)

* If a conda environment is not returned via the conda env list command, resolve it as unknown

* News entry

* Fix unit tests
* Do not use conda run when launching a debugger

* News

* Only build VSIX

* Revert "Only build VSIX"

This reverts commit 0ade929.
…18860)

* Fixes support for python binaries not following the standard names

* news

* Remove comment
* Do not validate conda binaries using shell

* Fix tests

* Fix lint

* Fix tests
* Fixed problem where match string contain special characters

* Fixes issue where () and | are escaped for windows

* Fixed a problem when some characters are not escaped.
Added Credits.

* Update src/client/common/process/logger.ts

Simplify code.

Co-authored-by: Kartik Raj <karraj@microsoft.com>

* Only replace '\\' with '(\\|/)' on Windows to save a scan on other OSs.

* Update src/client/common/process/logger.ts

Co-authored-by: Kartik Raj <karraj@microsoft.com>
Merge from release to main
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v2...v3)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [async](https://github.com/caolan/async) from 2.6.2 to 3.2.3.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/master/CHANGELOG.md)
- [Commits](caolan/async@v2.6.2...v3.2.3)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Basic test discovery (no server yet)

* Clean up test discovery script

* Add default test results array value (py side)

* Add localization

* Build tree on the Python side + move utils out

* Basic test discovery

* Add test tree update support

* Multiroot workspace support

* Make sure we don't shadow the "type" keyword

* Move discovery in a function

* Use pathlib everywhere

* News entry

* Add docstrings to utils tests + fix nested case

* Rename utils tests data + delete unused files

* Discovery tests

* Update comments + requirements

* Do not run test discovery for now

* Re-generate requirements using python 3.7

* Sort Python imports on save

* Get new server architecture up

* Add comment for tornado

* Apply Python suggestions from code review

Co-authored-by: Brett Cannon <brett@python.org>

* Pass test discovery adapter to workspace adapter

* Wrap nodes under test provider

* Let the OS pick a port

* traceLog when response processing errors out

Co-authored-by: Brett Cannon <brett@python.org>
…exist on filesystem (#18920)

* Fix support for selecting interpreter paths which are valid when run on shells

* Fix compile error
…n selected (#18928)

* Do not prompt to select new virtual envrionment if it has already been selected

* Add commnet
* Remove LSFolderService dependency

* No DI proof of concept

* Add safeguard when connecting/disconnecting

* Proper Pylance LS disposal

* Fix Jedi LS startup/disposal

* Add cache support

* Remove DI decorators + registry activation

* Do not reload window when Pylance not installed

* jedi/pylance/none extension managers

* languageServer/watcher.unit.test.ts

* News entry

* Add 2.7 behaviour + fix linting

* Remove deprecated LS settings

* Add support for 1 LS per workspace folder

* Add tests

* Update src/client/languageServer/watcher.ts

Co-authored-by: Kartik Raj <karraj@microsoft.com>

* Add resource path to "starting ls" message

* Fix issue with get()

* Amend ILanguageServerExtensionManager comment

Co-authored-by: Kartik Raj <karraj@microsoft.com>
Bumps [typing-extensions](https://github.com/python/typing) from 4.0.1 to 4.2.0.
- [Release notes](https://github.com/python/typing/releases)
- [Changelog](https://github.com/python/typing/blob/master/typing_extensions/CHANGELOG)
- [Commits](python/typing@4.0.1...4.2.0)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove process code from browser entry point

* Add news
…18977)

* Add verbose logging regarding discovery of conda envs

* Only build vsix

* Cleanup verbose logging

* Revert "Only build vsix"

This reverts commit 369bdf0.
* Delete refCountedLanguageServer.ts

* Stop LS is workspace folder removed

* Only one LS for Pylance and None

* Dispose LS in multiroot scenario only with Jedi
@mokeyish mokeyish closed this Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants