Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit SA1414 for interface implementations #3644

Merged
merged 6 commits into from
May 18, 2023
Merged

Don't emit SA1414 for interface implementations #3644

merged 6 commits into from
May 18, 2023

Commits on Apr 19, 2023

  1. Don't emit SA1414 for interface implementations

    @CollinAlpert
    CollinAlpert committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    f395c71 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Added tests for explicit interface implementations and base classes.

    @CollinAlpert
    CollinAlpert committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    22e8d6b View commit details
    Browse the repository at this point in the history

  2. Use DiagnosticResult.EmptyDiagnosticResults

    @CollinAlpert
    CollinAlpert committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    89e104f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Extend test cases to cover return types.

    @CollinAlpert
    CollinAlpert committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    339938b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Only query semantic model when absolutely necessary.

    @CollinAlpert
    CollinAlpert committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2543742 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Apply suggestions from code review

    @sharwell
    sharwell committed May 18, 2023
    Configuration menu
    Copy the full SHA
    bda8c5a View commit details
    Browse the repository at this point in the history