Constants #19
Merged
Constants #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBKP
requested review from
a1cd and
Ryan-Bauroth
and removed request for
a1cd
a1cd
requested changes
Jan 18, 2024
Comment on lines
28
to
33
| // *START OF CONSTANTS FOR SWERVE* (STILL MISSING WHEEL POSITIONS - Im not on the cad thingy so i | ||
| // cant see it) | ||
| double WHEEL_RADIUS = 0.0508; | ||
| double WHEEL_CIRCUMFERENCE = WHEEL_RADIUS * 2 * PI; | ||
| double DRIVE_GEAR_RATIO = 6.75; | ||
| double STEERING_RATIO = (150 / 7); |
There was a problem hiding this comment.
may want to remove them or comment them out if we don't use them.
a1cd
approved these changes
Jan 18, 2024
Co-authored-by: Everett Wilber <71281043+a1cd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.