-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manipulator #7
base: dev
Are you sure you want to change the base?
Manipulator #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bunch of comments. They have suggestions you can easily approve if you want to but make sure to read them first
src/main/java/frc/robot/subsystems/manipulator/Manipulator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/Manipulator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/Manipulator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/commands/manipulator/SetManipulatorSpeed.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Show resolved
Hide resolved
private final RelativeEncoder encoder; | ||
private final SparkMaxPIDController pid; | ||
|
||
public ManipulatorIOSparkMax(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want you can make motor id a parameter, but it will work this way as well
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIO.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Everett Wilber <71281043+a1cd@users.noreply.github.com>
Co-authored-by: Everett Wilber <71281043+a1cd@users.noreply.github.com>
src/main/java/frc/robot/commands/manipulator/SetManipulatorSpeed.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Outdated
Show resolved
Hide resolved
Quick simple compilation failures
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice effort, still untested code and it is not used in robot container but it looks like it should work properly.
@Ryan-Bauroth Merge it when you want to |
Can someone make sure all this code looks good? I think it all should work but I am unsure about the init() function and just general IO things being correct. Thanks!