Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CSS Windows import statement #8

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

markoboy
Copy link
Contributor

Hello and thank you for this plugin. I had an issue when trying to bundle the svelte app with css option set to false on Windows 10 system with Node v14.

Screenshot error:

image

After my PR the issue is fixed. It will replace forward slashes (\) with backward slashes (/) for the import to work.

image

@EMH333 EMH333 self-assigned this Nov 22, 2020
@EMH333 EMH333 self-requested a review November 22, 2020 01:26
@EMH333 EMH333 added the bug Something isn't working label Nov 22, 2020
@EMH333
Copy link
Owner

EMH333 commented Nov 22, 2020

Sweet, thank you for this fix! I am a bit too busy for testing and a release at the moment (next 12-24 hrs) but I'll get this merged in the next couple days

Thanks once again!

@EMH333 EMH333 merged commit f992a24 into EMH333:main Nov 22, 2020
@EMH333
Copy link
Owner

EMH333 commented Nov 22, 2020

This has been merged and released as a part of 0.3.1. Thanks!

@markoboy
Copy link
Contributor Author

Thank you too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants