Updated Triplestore.add_function() to also support EMMO. #67
Conversation
Codecov ReportBase: 67.06% // Head: 67.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 67.06% 67.07% +0.01%
==========================================
Files 14 14
Lines 1014 1063 +49
==========================================
+ Hits 680 713 +33
- Misses 334 350 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tripper/triplestore.py
Outdated
| hasInput = EMMO.EMMO_36e69413_8c59_4799_946c_10b05d266e22 | ||
| hasOutput = EMMO.EMMO_c4bace1d_4db0_4cd3_87e9_18122bae2840 | ||
| # Software = EMMO.EMMO_8681074a_e225_4e38_b586_e85b0f43ce38 | ||
| # hasSoftware = EMMO.Software # TODO: fix |
There was a problem hiding this comment.
How hard would this be to fix? Can you provide more information?
There was a problem hiding this comment.
It requires that we add the hasSoftware object property to EMMO - easy to do, but will take time since it should be quickly discussed in the EMMO team
There was a problem hiding this comment.
No problem. Just write something like "requires the hasSoftware object property which is not currently implemented in EMMO". This will make it easier if someone other than you ends up fixing the todo :)
tripper/triplestore.py
Outdated
| @@ -646,3 +658,55 @@ def _add_function_fno(self, func, expects, returns, base_iri): | |||
| lst = lst_next | |||
|
|
|||
| return func_iri | |||
|
|
|||
| def _add_function_emmo(self, func, expects, returns, base_iri): | |||
| """Implementing add_function() for EMMO.""" | |||
There was a problem hiding this comment.
Do we need a docstring? E.g, I have no clue what this function it does or what its arguments are for...
There was a problem hiding this comment.
This is an EMMO-specific implementation of the public method add_function(), which is documented above.
I will add a few more words...
| @@ -0,0 +1,119 @@ | |||
| """Test Triplestore.add_function()""" | |||
| # pylint: disable=invalid-name | |||
There was a problem hiding this comment.
Very glad to see test added with the code :)
jesper-friis
requested review from
daniel-sintef
and removed request for
francescalb
Closes #65