Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health check alarms #193

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Add health check alarms #193

merged 1 commit into from
Dec 25, 2022

Conversation

Pliner
Copy link
Member

@Pliner Pliner commented Dec 25, 2022 •
edited
Loading

@Pliner Pliner merged commit b41b5c1 into master Dec 25, 2022
@Pliner Pliner deleted the health-check-alarms branch December 25, 2022 11:32
sungam3r
sungam3r reviewed Dec 25, 2022
View reviewed changes
Source/EasyNetQ.Management.Client/ManagementClient.cs
{
return GetAsync<IReadOnlyList<Consumer>>(Consumers, cancellationToken);
using var request = CreateRequest(HttpMethod.Get, path);
using var response = await httpClient.SendAsync(request, cancellationToken).ConfigureAwait(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to use HttpCompletionOption.ResponseHeadersRead here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

29e9e8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r left review comments

@zidad zidad Awaiting requested review from zidad zidad is a code owner

@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner

@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for healthcheck-requests
2 participants
@Pliner @sungam3r