Redact inside extra too #9595

Ecodev · Oct 18, 2023 · b978c0f · b978c0f
1 parent 6db377c
commit b978c0f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Log/EventCompleter.php b/src/Log/EventCompleter.php
@@ -27,7 +27,9 @@ public function process(array $event): array
         }
 
         // Security hide clear text password
-        unset($event['extra']['password']);
+        if (isset($event['extra'])) {
+            $event['extra'] = $this->redactSensitiveData($event['extra']);
+        }
 
         return $event;
     }

diff --git a/tests/Log/EventCompleterTest.php b/tests/Log/EventCompleterTest.php
@@ -59,10 +59,15 @@ public function testProcess(): void
             'message' => '',
             'extra' => [
                 'errno' => 1,
+                'password' => 'sensitive',
             ],
         ]);
 
         self::assertStringContainsString('Stacktrace:', $actual['message']);
+        self::assertSame([
+            'errno' => 1,
+            'password' => '***REDACTED***',
+        ], $actual['extra']);
         self::assertSame(123, $actual['creator_id']);
         self::assertSame('my login', $actual['login']);
         self::assertIsString($actual['url']);