Fix file URL double-encoding #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
added a commit
to cozy/SocialSharing-PhoneGap-Plugin
that referenced
this pull request
Nov 19, 2019
|
@EddyVerbruggen this is still an issue in the plugin. It would be wonderful to resolve it. This currently means the plugin doesn't work if a file URL is supplied that contains % encoding. |
|
If there are concerns about backwards compatibility due to JavaScript code creating invalid |
Crash--
added a commit
to cozy/SocialSharing-PhoneGap-Plugin
that referenced
this pull request
Jan 2, 2023
If the file URL contains percent encoding then the percent encodings are re-encoded, as we treat the already encoded string as a path, so NSURL re-encodes it. We can assume that if the string begins file:// that it is a legal file URL, in which case we can simply use [NSURL URLWithString].
karlvr
force-pushed
the
fix-file-url-encoding
branch
from
d00a8cf
to
68533b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file URL contains percent encoding then the percent encodings are re-encoded, as we treat the already encoded string as a path, so NSURL re-encodes it. We can assume that if the string begins file:// that it is a legal file URL, in which case we can simply use [NSURL URLWithString].