Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update android param value #455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update android param value #455

wants to merge 2 commits into from

Conversation

trekkie4life
Copy link

  • fix discrepancy between it and generated cordova module in JS that causes the error seen below
  • make it reflective of current plugin name in npm

screen shot 2015-11-04 at 15 23 59

@trekkie4life
Update value for android-package in plugin.xml to
4213cde 
- fix discrepancy between it and generated cordova module in JS
that causes an error
- make it reflective of current plugin name in npm
@trekkie4life
update version patch number from 5.0.6 to 5.0.7
3de020f
@trekkie4life
Copy link
Author

see issue #454

@EddyVerbruggen
Copy link
Owner

Hey @trekkie4life that's not the approach other plugins take. F.i. see the splashscreen plugin's package: https://github.com/apache/cordova-plugin-splashscreen/blob/master/plugin.xml#L43

I need to find time to check this out, but I don't think I'll go this route..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trekkie4life @EddyVerbruggen