Update tapadoo and allow bottom position in android #65

EddyVerbruggen · Jun 21, 2020 · 11985a0 · 11985a0
1 parent 3f36b9e
commit 11985a0
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 11 deletions.
diff --git a/demo-vue/app/components/App.vue b/demo-vue/app/components/App.vue
@@ -29,7 +29,7 @@
         feedback.show({
           title: "Thumbs up!",
           titleColor: new Color("#222222"),
-          position: FeedbackPosition.Bottom, // iOS only
+          position: FeedbackPosition.Bottom,
           type: FeedbackType.Custom, // this is the default type, by the way
           message: "Custom colors and icon. Loaded from the App_Resources folder.",
           messageColor: new Color("#333333"),

diff --git a/demo-vue/app/package.json b/demo-vue/app/package.json
@@ -1,6 +1,7 @@
 {
   "android": {
-    "v8Flags": "--expose_gc"
+    "v8Flags": "--expose_gc",
+    "markingMode": "none"
   },
   "main": "main",
   "name": "demo-vue",

diff --git a/demo/app/main-page.xml b/demo/app/main-page.xml
@@ -9,7 +9,7 @@
         <Button text="Info, 2s" tap="{{ showInfo }}" class="button button-info" />
         <Button text="Warning, 4s" tap="{{ showWarning }}" class="button button-warning" />
         <Button text="Error, 1s" tap="{{ showError }}" class="button button-error" />
-        <Button text="Error, 5s, Bottom (iOS)" tap="{{ showErrorBottom }}" class="button button-error" />
+        <Button text="Error, 5s, Bottom" tap="{{ showErrorBottom }}" class="button button-error" />
         <Button text="No icon" tap="{{ showNoIcon }}" class="button button-custom" />
         <Button text="Custom icon" tap="{{ showCustomIcon }}" class="button button-custom-alt" />
         <Button text="Custom font" tap="{{ showCustomFont }}" class="button button-font" />

diff --git a/demo/app/package.json b/demo/app/package.json
@@ -26,7 +26,8 @@
   },
   "homepage": "https://github.com/NativeScript/template-hello-world-ts",
   "android": {
-    "v8Flags": "--expose_gc"
+    "v8Flags": "--expose_gc",
+    "markingMode": "none"
   },
   "devDependencies": {
     "nativescript-dev-typescript": "^0.3.0"

diff --git a/demo/package.json b/demo/package.json
@@ -2,10 +2,10 @@
   "nativescript": {
     "id": "org.nativescript.plugindemo.feedback",
     "tns-android": {
-      "version": "6.0.1"
+      "version": "6.5.0"
     },
     "tns-ios": {
-      "version": "6.0.1"
+      "version": "6.5.0"
     }
   },
   "dependencies": {
@@ -24,7 +24,7 @@
     "karma-nativescript-launcher": "^0.4.0",
     "lazy": "1.0.11",
     "nativescript-css-loader": "~0.26.1",
-    "nativescript-dev-webpack": "1.0.1",
+    "nativescript-dev-webpack": "~1.5.0",
     "tns-platform-declarations": "~6.0.6",
     "tslint": "~5.4.3",
     "typescript": "3.4.5",

diff --git a/src/feedback.android.ts b/src/feedback.android.ts
@@ -3,7 +3,7 @@ import * as application from "tns-core-modules/application";
 import * as utils from "tns-core-modules/utils/utils";
 import { Color } from "tns-core-modules/color";
 
-declare let com, android, Gravity: any;
+declare let com, android: any;
 
 export { FeedbackType };
 export { FeedbackPosition };

diff --git a/src/package.json b/src/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nativescript-feedback",
-  "version": "1.3.12",
+  "version": "1.4.0",
   "description": "Non-blocking textual feedback for your NativeScript app. AKA superfancy Toasts!",
   "main": "feedback",
   "typings": "index.d.ts",
@@ -59,8 +59,8 @@
   "homepage": "https://github.com/EddyVerbruggen/nativescript-feedback",
   "readmeFilename": "README.md",
   "devDependencies": {
-    "tns-core-modules": "~5.4.0",
-    "tns-platform-declarations": "~5.4.0",
+    "tns-core-modules": "~6.5.8",
+    "tns-platform-declarations": "~6.5.8",
     "typescript": "~3.1.0",
     "prompt": "^1.0.0",
     "rimraf": "^2.6.2",