-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback not showing on fullscreen MODAL page on Android #11
Comments
I don't think we can do anything about that as it's likely to be internal to the library we're wrapping here. Just to be sure: can you share a project that reproduces the issue? |
Hi @EddyVerbruggen, here is the sample project: Feedback shows up on the modal page on iOS but doesn't on Android where it's basically hidden behind the page. Does it do something with elevation on Android? |
How do I get the feedback's nativeView? |
Thanks for the sample, I can confirm the modal blocks the view. The LoC responsible for adding the alert to the view is this one. |
Ok, thanks, seems it's possible to get access to the native view by the reference |
It's worth a shot. |
Any updates here @EddyVerbruggen ? |
No. |
Hey @EddyVerbruggen any idea if the plugin still works with the tns-core-modules changes after 4.0? No toasts seem to show, and I haven't had time to troubleshoot it. |
@Pip3r4o I’m using it in this app which has all the latest bits: https://github.com/EddyVerbruggen/nativescript-pluginshowcase Or are you referring to using it in a modal? I’ve never tried that. |
@EddyVerbruggen if a modal is active n then the feedback is called, it shows behind the modal, so for me i had to close the modal to show the user the feedback, which is annoying.. |
@mhmo91 that will supposedly be the native behavior too. |
need this too |
I can't find a way to make it work. Leaving this open for others to take a stab. |
When the modal works, it displays something like - |
Just some food for thought, I personally had it not working too, until I realized that I am opening up the modal in an async await making it run in a background thread instead of the UI thread, thus making it impossible for it draw on the UI thread. |
@sanved77 all the Javascript in NS runs on the UI thread. Only things running in a worker don't run in on the UI thread. |
I made a fix to at least be able to make the notification appear when in a dialog. |
@jerbob92 I've tried your solution on my project but still not working... It looks like the EDIT: ok my bad, I've looked at your commit and the plugin has to be updated first. Thanks. |
@EddyVerbruggen @jerbob92 |
Yes, that does sound like it will fix it. You could try it out :) |
I could and would like to, but I don't know how to write NativeScript plugins that use native components 😢 |
@MrSnoozles I don't think you have to develop anything. You can probably add something to your app gradle file to force the new version of the native component:
|
@MrSnoozles After looking at the changes of the project we might need to make some changes to support showing in a dialog indeed. We probably still need to detect whether we are in a modal like I put in this MR: We then need to pass the dialog into the constructor of the Alerter. |
Feedback doesn't show up on fullscreen modal page on Android.
nativescript CLI 3.2.1
tns-core-modules 3.2.0
tns-android 3.2.0
nativescript-feedback 1.0.6
Android 7.1
The text was updated successfully, but these errors were encountered: