Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Toast inside of modal (Android) #477

Closed
hafstad opened this issue Aug 1, 2019 · 5 comments
Closed

[BUG] Toast inside of modal (Android) #477

hafstad opened this issue Aug 1, 2019 · 5 comments

Comments

@hafstad
Copy link
Contributor

hafstad commented Aug 1, 2019

Describe the bug
If you open a toast inside of a modal, the toast will open behind the modal.

To Reproduce

  1. Open a modal
  2. Open a toast from the modal

Kirby version

  • v.0.0.237

Expected behavior
The toast should always open on top so it's visible

Native (please complete the following information):
Issue has been confirmed on Android however it maybe also affects iOS

@mmmtrifork mmmtrifork self-assigned this Aug 1, 2019
@mmmtrifork mmmtrifork changed the title [BUG] Toast inside of modal [BUG] Toast inside of modal (Android) Aug 1, 2019
@mmmtrifork
Copy link
Contributor

This seems to be an issue with nativescript-feedback: EddyVerbruggen/nativescript-feedback#11

I have tested it on both iOS and Android and the problem only appears on Android

@mmmtrifork mmmtrifork removed their assignment Aug 2, 2019
@adfdev
Copy link

adfdev commented Aug 2, 2019

This seems to be an issue with nativescript-feedback: EddyVerbruggen/nativescript-feedback#11

I have tested it on both iOS and Android and the problem only appears on Android

yes only in android! Solution?

@sanved77
Copy link

Just some food for thought, I personally had it not working too, until I realized that I am opening up the modal in an async await making it run in a background thread instead of the UI thread, thus making it impossible for it draw on the UI thread.
And when it tries to draw it on the background thread, the DecorView doesn't get the View to draw on and throws an exception which is being caught by the JS.
You can try and set this to false under package.json to experiment - discardUncaughtJsExceptions

@mmmtrifork
Copy link
Contributor

This seems to be an issue with nativescript-feedback: EddyVerbruggen/nativescript-feedback#11
I have tested it on both iOS and Android and the problem only appears on Android

yes only in android! Solution?

Unfortunately not.

@ckibsen
Copy link
Contributor

ckibsen commented Sep 5, 2019

RIP {N}

@ckibsen ckibsen closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants