Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools - drop support for phpcs v2 #232

Merged
merged 1 commit into from
May 13, 2021
Merged

Tools - drop support for phpcs v2 #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .phpqa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ report:
tool:
phpmetrics: [Edge\QA\Tools\Analyzer\PhpMetrics, Edge\QA\Tools\Analyzer\PhpMetricsV2]
phploc: Edge\QA\Tools\Analyzer\Phploc
phpcs: [Edge\QA\Tools\Analyzer\Phpcs, Edge\QA\Tools\Analyzer\PhpcsV3]
phpcs: Edge\QA\Tools\Analyzer\Phpcs
php-cs-fixer: Edge\QA\Tools\Analyzer\PhpCsFixer
phpmd: Edge\QA\Tools\Analyzer\Phpmd
pdepend: Edge\QA\Tools\Analyzer\Pdepend
Expand Down
49 changes: 11 additions & 38 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/Tools/Analyzer/Phpcs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class Phpcs extends \Edge\QA\Tools\Tool
true => '//checkstyle/file/error[@severity="error"]',
],
'composer' => 'squizlabs/php_codesniffer',
'internalClass' => 'PHP_CodeSniffer',
);

public function __invoke()
Expand Down
17 changes: 0 additions & 17 deletions src/Tools/Analyzer/PhpcsV3.php
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/.ci/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ parameters:
- %currentWorkingDirectory%/src/Task/NonParallelExecV0.php
- %currentWorkingDirectory%/src/Task/NonParallelExecV1.php
- %currentWorkingDirectory%/src/Task/RoboAdapter.php
- %currentWorkingDirectory%/src/Tools/Analyzer/Phpcs.php
- %currentWorkingDirectory%/src/Tools/Analyzer/PhpcsV3.php
ignoreErrors:
- '#Call to an undefined method Prophecy\\Prophecy\\ObjectProphecy::[a-zA-Z0-9_]+\(\)#'
- '#Constant [A-Z_]+ not found#'
13 changes: 1 addition & 12 deletions tests/.ci/psalm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,7 @@
<directory name="src/Tools/Analyzer" />
<directory name="src/Task" />
</errorLevel>
</UnusedClass>
<UndefinedClass>
<errorLevel type="info">
<file name="src/Tools/Analyzer/Phpcs.php" />
<file name="src/Tools/Analyzer/PhpcsV3.php" />
</errorLevel>
</UndefinedClass>
</UnusedClass>
<PossiblyUnusedMethod>
<errorLevel type="info">
<file name="src/CodeAnalysisTasks.php" />
Expand All @@ -43,11 +37,6 @@
<file name="src/Task/ParallelExec.php" />
</errorLevel>
</InvalidReturnType>
<UnresolvableInclude>
<errorLevel type="info">
<file name="src/Tools/Analyzer/PhpcsV3.php" />
</errorLevel>
</UnresolvableInclude>
<DeprecatedMethod errorLevel="info" />

<!-- Ignored rules -->
Expand Down