Integrate the SPIR-T qptr experiment.
#1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
changed the title
qptr experiment.qptr experiment.
eddyb
force-pushed
the
qptr-integration
branch
2 times, most recently
from
5c9b094
to
eaae277
Compare
oisyn
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information, check out the SPIR-T PR, which has a much longer explanation:
qptr("quasi-pointer") type and associated lower->analyze->lift passes. spirt#24The short version is goes something like this:
Currently this PR allows testing replacing the old storage class inference with
qptrpasses, via:RUSTGPU_CODEGEN_ARGS="--no-infer-storage-classes --spirt-passes=qptr"