Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --no-spirt and the old structurizer. #1052

Merged
merged 5 commits into from
May 19, 2023

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Apr 24, 2023

The test commits should be reviewed separately, as I tried to not mix the different kinds of changes to them.


The --no-spirt documentation and changelog have this note in them:

Note: if you were using --no-spirt to work around naga issue #1977
(valid loops causing The 'break' is used outside of a 'loop' or 'switch' context),
you may be able to cargo update -p naga to update to a fixed naga version
(0.11.1 for wgpu 0.15, 0.12.1 for wgpu 0.16, and any later versions).

Hopefully that's detailed enough, but I expect the release notes to expand on it even more.
(It's looking like Rust-GPU 0.8 will mostly only be this change, which should make it even harder to miss)

@eddyb eddyb marked this pull request as ready for review May 19, 2023 01:42
@eddyb eddyb requested review from VZout, repi and fu5ha May 19, 2023 01:45
Copy link
Member

@fu5ha fu5ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I didn't review super thoroughly but it all looks reasonable to me and super exciting!! Great work on spirt and exciting to see it beginning to bear more and more fruit :)

Copy link
Contributor Author

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another skim myself to confirm that none of the test changes broke anything.

@eddyb eddyb merged commit 2bac7c1 into EmbarkStudios:main May 19, 2023
@eddyb eddyb deleted the spirt-only branch May 19, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing --no-spirt (and outdated codepaths) in Rust-GPU 0.8.
2 participants