Support GLSL450 and Simple memory models #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
reviewed
Oct 28, 2020
Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
msiglreith
reviewed
Oct 28, 2020
| let mut builder = Builder::new(); | ||
| // Default to spir-v 1.3 | ||
| let version = version.unwrap_or((1, 3)); | ||
| builder.set_version(version.0, version.1); | ||
| let memory_model = memory_model.unwrap_or(MemoryModel::Vulkan); | ||
| if kernel_mode { | ||
| builder.capability(Capability::Kernel); | ||
| } else { | ||
| builder.extension("SPV_KHR_vulkan_memory_model"); |
There was a problem hiding this comment.
is this extension actually needed?
There was a problem hiding this comment.
Yes, the vulkan memory model isn't present for spir-v versions less than 1.5. I'll fix this, though.
Jasper-Bekkers
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
I think this is fine to have for now, but I think it would be a mistake to try to support GLSL or anything other then the Vulkan Memory Model if we run into complex memory model issues. For example, if we discuss around subgroup operations, I think that topic might already be tricky enough without the additional implications that OpenGL / GLSL450 brings (if any).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
Only smoke-tested building the example-shader shader on both Simple and GLSL450 models, seems to work. We might want to set up tests for both all the spir-v versions and this going forwards.