Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry point attribute configuration. #458

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Add entry point attribute configuration. #458

merged 7 commits into from
Mar 2, 2021

Conversation

XAMPPRocky
Copy link
Member

@XAMPPRocky XAMPPRocky commented Mar 1, 2021

Adds an nested entry_point attribute to all the execution models attributes. This allows you to override the OpEntryPoint for a given entry point with your own name.

Example

#[allow(unused_attributes)]
#[spirv(fragment(entry_point_name="hello_world"))]
pub fn main() { }

@eddyb

This comment has been minimized.

@XAMPPRocky XAMPPRocky requested a review from eddyb March 2, 2021 08:16
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove #[allow(unused_attributes)] from the PR description and the test, and rebase past #461.

@eddyb eddyb merged commit 6678f9a into main Mar 2, 2021
@eddyb eddyb deleted the entrypoint-attr branch March 2, 2021 13:30
@khyperia khyperia removed their request for review March 23, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants