Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a #[spirv(...)] attribute checking pass and remove #[allow(unused_attributes)]. #461

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Add a #[spirv(...)] attribute checking pass and remove #[allow(unused_attributes)]. #461

merged 6 commits into from
Mar 2, 2021

Commits on Mar 1, 2021

  1. parse_attrs: avoid unnecessary allocation.

    @eddyb
    eddyb committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fd6a77e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. symbols: use Results to keep track of attribute parsing errors.

    @eddyb
    eddyb committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0fd90a7 View commit details
    Browse the repository at this point in the history

  2. symbols: rename #[spirv(image(...))] to #[spirv(image_type(...))].

    @eddyb
    eddyb committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    a7296d1 View commit details
    Browse the repository at this point in the history

  3. symbols: cache a Rc<Symbols> per thread.

    @eddyb
    eddyb committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    fb33cce View commit details
    Browse the repository at this point in the history

  4. attr: add a pre-codegen #[spirv(...)] attribute checking pass.

    @eddyb
    eddyb committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    1096283 View commit details
    Browse the repository at this point in the history

  5. attr: mark #[spirv(...)] attributes as used and remove `#[allow(unu… 

    …sed_attributes)]`.
    @eddyb
    eddyb committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    06a8c2e View commit details
    Browse the repository at this point in the history