feat: Added instructions for depth reference and project coordinate image instructions #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! You might want to wait for #533 to merge or run the tests on top of this, as I'm pretty sure these tests will fail validation for Vulkan environments with the uniforms missing their descriptor set and binding. Can you update those tests to ensure they compile for Minor nit: could you also add a blank line between each of the methods? |
DeanBDean
force-pushed
the
add-depth-reference-instructions
branch
from
f513a61
to
ff85f68
Compare
|
Okay, I fixed the line spacing and will wait on #533 and update accordingly |
DeanBDean
force-pushed
the
add-depth-reference-instructions
branch
2 times, most recently
from
29127c9
to
57e17b3
Compare
|
@DeanBDean Those changes have landed now so a rebase so be all that's needed to get this merged. |
DeanBDean
force-pushed
the
add-depth-reference-instructions
branch
from
73040e3
to
6d2db9a
Compare
XAMPPRocky
approved these changes
Mar 30, 2021
|
Thank you for your PR! |
XAMPPRocky
pushed a commit
that referenced
this pull request
May 3, 2021
…mage instructions (#545) * feat: Added instructions for depth reference and project coordinate image instructions * docs: add alias annotation for methods in spirv-std/src/textures.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the following instructions
OpImageSampleProjImplicitLod
OpImageSampleProjExplicitLod
OpImageSampleProjDrefImplicitLod
OpImageSampleProjDrefExplicitLod
OpImageSampleDrefImplicitLod
OpImageSampleDrefExplicitLod
as noted here #383