Fix semantics type for control barriers to support multiple flags #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
force-pushed
the
control-barrier
branch
from
b144e4f
to
e60dd3f
Compare
msiglreith
force-pushed
the
control-barrier
branch
from
e60dd3f
to
70661b9
Compare
|
Thank you for PR! I think we might as well switch the |
msiglreith
force-pushed
the
control-barrier
branch
from
aafc5b5
to
da6d68d
Compare
|
Pushed a change with converting the enum to bitflags after the discussion on discord. |
XAMPPRocky
reviewed
Apr 22, 2021
XAMPPRocky
approved these changes
Apr 22, 2021
Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
XAMPPRocky
added a commit
that referenced
this pull request
May 3, 2021
* Fix semantics type for control barriers to support multiple flags * spirv-std: convert memory semantics to bitflag * Update crates/spirv-std/src/arch/barrier.rs Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com> Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #581
control_barrierAPI now matchesmemory_barrierby using au32instead of an enum type for specifyingSemanticsbitflags.