Add spirv-val flags to spirv-builder #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
May 26, 2021
| // spirv-val flags | ||
| pub relax_struct_store: bool, | ||
| pub relax_logical_pointer: bool, | ||
| pub relax_block_layout: Option<bool>, |
There was a problem hiding this comment.
So this is basically a tri-state? It stands out a bit here, maybe deserves a comment (although this is kind of a deep location).
There was a problem hiding this comment.
Yeah, it's... a little weird? Even weirder is that I don't think the CLI of spirv-val exposes this tri-state, it's only Some(true) and None. I thiiiink the tri-state is:
Some(true)-> force relax-block-layout onSome(false)-> force relax-block-layout offNone-> relax-block-layout is on if vulkan version >=1.1, off if ==1.0
hrydgard
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
Went a little overboard and added all the spirv-val flags instead of just
--scalar-block-layout, figured we'd want them eventually.Also, fixed a nasty bug where spirv-opt wasn't being passed the target environment (but spirv-val was), that was a little spooky to find.