Add a preserve_bindings opt to the builder and codegen opts #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the best option here is the second alternative: adding a new option to spirv-builder. Removing unused bindings is the default of other shader compilers, as well as a lot of tooling, and is usually the desired behavior AFAIK. Adding an option for alternate use cases seems like the way to go. |
expenses
changed the title
spirv_tools::opt::Options::preserve_bindings to true unconditionally
|
@khyperia done. |
expenses
changed the title
…r lines above, making the styling of the file fairly inconsistent. Well, whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #827 and makes reflection a lot easier. I think having it set to true unconditionally is the right move but two alternatives are:* Setting it tocg_args.spirv_metadata != SpirvMetadata::None. This is pretty unclear behaviour but it does keep things the same in the default case.CodegenArgs::opt_preserve_bindingsargument. Adds more complexity and is easily missed. Doesn't really 'just work'.