Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare invalid-target test for #926 #929

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Prepare invalid-target test for #926 #929

merged 2 commits into from
Oct 19, 2022

Conversation

oisyn
Copy link
Contributor

@oisyn oisyn commented Oct 19, 2022

This PR adds the commented out use spirv_std::spirv; to invalid-target.rs in preparation for #926

@oisyn oisyn requested a review from eddyb as a code owner October 19, 2022 08:18
@oisyn oisyn enabled auto-merge (squash) October 19, 2022 08:19
@oisyn oisyn changed the title Invalid target test Prepare invalid-target test for #926 Oct 19, 2022
Comment on lines 30 to 31
// * 6 on `_entry_param`
// * 1 on `_closure`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay good, this accounting (expand to see it above, these are just the last 2 lines of a dozen) is still correct most likely, total error count is still 473.

@oisyn oisyn merged commit 0811739 into main Oct 19, 2022
@oisyn oisyn deleted the invalid-target-test branch October 19, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants