Exposing ECR lifecycle policy as a variable #110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ravisinghkr
commented
Jan 30, 2024
•
ravisinghkr
commented
- Exposing repository_lifecycle_policy as an optional variable and making existing policy as default.
- Making max_tagged_image_count as optional as it wont be used in case repository_lifecycle_policy is provided
ravisinghkr
requested review from
russellseymour,
balpurewal,
dibyadhar and
ElvenSpellmaker
dibyadhar
approved these changes
Jan 30, 2024
| @@ -64,3 +66,9 @@ variable "pull_through_cache_accounts" { | |||
| description = "A default list of accounts for the Pull Through Cache if not configured in the `pull_through_cache_setup`. Defaults to the calling account root" | |||
| default = [] | |||
| } | |||
|
|
|||
| variable "repository_lifecycle_policy" { | |||
| type = any | |||
There was a problem hiding this comment.
This possibly should be a strongly typed object and if null is passed use the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.