Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: count on the custom domain #135

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: count on the custom domain #135

merged 1 commit into from
Aug 13, 2024

Conversation

ElvenSpellmaker
Copy link
Contributor

📲 What

count on the custom domain

🤔 Why

The module is broken if CDN isn't enabled due to a missing count

🛠 How

👀 Evidence

🕵️ How to test

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

russellseymour
russellseymour approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@russellseymour russellseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ElvenSpellmaker ElvenSpellmaker merged commit 63bc257 into master Aug 13, 2024
2 checks passed
@ElvenSpellmaker ElvenSpellmaker deleted the fix/cdn-ss-module branch August 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellseymour russellseymour russellseymour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElvenSpellmaker @russellseymour