This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Use mediasoup's internal stream ids for SCTP to avoid clashes #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow more than 2 peers to connect to the SFU without having Unreal Engine crash from stream channels being double-assigned
StomyPX
force-pushed
the
unify_stream_ids
branch
from
39c69d5
to
dbb4cdf
Compare
lukehb
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Moving to using the internal allocation of stream ids that mediasoup is doing under the hood. Slightly risky using internal API, but I think we are okay with this for now if it fixes the issue.
@mcottontensor for your review also.
|
Looks alright to me. |
|
This addresses: #62 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow more than 2 peers to connect to the SFU without having Unreal Engine crash from stream channels being double-assigned.
Fixes #62