This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix datachannels when using an SFU #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages. This is kind of a nasty exception for when the SFU sends it's data channel negotiations.
lukehb
suggested changes
Mar 2, 2023
| @@ -307,7 +307,9 @@ class Player { | |||
| return; | |||
| } | |||
|
|
|||
| message.playerId = this.id; | |||
| if (!message.playerId) { | |||
There was a problem hiding this comment.
Behaviour is quite nuanced, I feel a comment is necessary here saying something about player id might be already set in some cases (such as sfu datachannels) so we don't want to blanket overwrite it
lukehb
approved these changes
Mar 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where only the last joined peer could interact with the given streamer so now all peers should be able to interact by default.
The problem was that the new signalling server was making some assumptions about messages being sent from players and would unconditionally add the playerId field to the message with the sending player. Unfortunately the streamerDataChannels message used that field to specify the id of the player we were creating the data channel for. Without this fix, the data channel would always get the player id of the SFU and not the requesting player.