-
Notifications
You must be signed in to change notification settings - Fork 263
Conversation
Frontend/library/src/PeerConnectionController/PeerConnectionController.ts
Show resolved
Hide resolved
Huge one! That's awesome, we should leverage (if possible) having a public repo to integrate coverage reports into PRs to keep track and avoid merging PRs without enough coverage. Since this is a library aimed to be consumed by multiple clients that can also help on external contributions, but I'm probably thinking too far ahead (?) |
Amazing PR! Great work. A few additional requests on top of the comments I have already left:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments.
99c3cc5
to
4a69f21
Compare
This reverts commit 05f5742.
Added an action that runs the unit tests if
Done in a1c9f46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Summary
Added some Unit tests for the library project:
npm run test
Test Plan