This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Added "media-playout" to prevent spam in Aggregated Stats #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Hassebrook <chasse20@gmail.com>
Signed-off-by: Chris Hassebrook <chasse20@gmail.com>
Also pushed AggregatedStats.ts
Signed-off-by: Chris Hassebrook <chasse20@gmail.com>
lukehb
approved these changes
Jun 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Many browser versions don't yet support the "media-playout" stats type which causes flooding spam in the console, making it impossible to debug. This is a simple fix to stop that.
See: media-playout
Solution
Default cases it out like similar other stats. Also it appears Typescript hasn't updated their definition of RTCStatsType enum to include "media-playout" yet. That's annoying.