Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Update Dockerfile #293

Closed
wants to merge 1 commit into from
Closed

Update Dockerfile #293

wants to merge 1 commit into from

Conversation

kpradp
Copy link

@kpradp kpradp commented Jul 11, 2023

fix an error with directory doesnt exists

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

What problem does this PR address?

Error when building docker image.
Directory doesnt exist error in linux machines.

Solution

How does this PR solve the problem?
Fix for 5.2 same as 5.3

Documentation

If you added a new feature or changed an existing feature please add some documentation here.

Or better yet, link to the relevant /Docs update in your PR.

Test Plan and Compatibility

What steps have you taken to ensure this PR maintains compatibility with the existing functionality?

Or better yet, link to the unit tests that accompany this PR.

fix an error with directory doesnt exists
@kpradp
Copy link
Author

kpradp commented Jul 11, 2023

fix based on 5.3 branch

@Belchy06
Copy link
Collaborator

Hey @kpradp,

This PRs been superseded by #338 where we removed the two separate dockerfiles in favour of a single file.

It's worth noting that if you're trying to run this locally, you'll need to inform the docker build process that the context should actually be one file lower (eg it should be PixelStreamingInfra instead of PixelStreamingInfra/SignallingWebServer). If you don't do this, you'll likely see errors about the SignallingWebServer or Frontend folder not being found.

An example of how this can be done can be seen in our platform scripts here.

Cheers!

@Belchy06 Belchy06 closed this Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants