Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add: DataChannel Latency Test #311

Closed
wants to merge 4 commits into from

Conversation

gingernaz
Copy link
Contributor

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Measure data channel latency

Solution

Introducing a new test that will show data channel latency values

Documentation

To start the test:

  • Open stats panel
  • Hit Run Test button under Data Channel Latency Test
  • Wait for the results

Test Plan and Compatibility

Compatible with the latest main

@lukehb
Copy link
Contributor

lukehb commented Jul 18, 2023

Just confirming backwards compatibility is preserved?

For example, are the following cases met:

  1. For users on older versions of UE does this silently fail (if so, good!)?
  2. Likewise, for the UE side changes, if they are using the old frontend (without this change) does it still stream no problems (if so good!).

@gingernaz
Copy link
Contributor Author

gingernaz commented Jul 18, 2023

Just confirming backwards compatibility is preserved?

For example, are the following cases met:

  1. For users on older versions of UE does this silently fail (if so, good!)?
  2. Likewise, for the UE side changes, if they are using the old frontend (without this change) does it still stream no problems (if so good!).

Just double-checked this.
Users with older versions of UE will get NaN values with the test. Users of the older frontend are still able to stream with no problems.

@Belchy06 Belchy06 added this to the 5.3 milestone Jul 18, 2023
@Belchy06 Belchy06 added the enhancement New feature or request label Jul 18, 2023
@Belchy06 Belchy06 changed the title Dc latency test Add: DataChannel Latency Test Jul 18, 2023
Signed-off-by: Nazar Rudenko <nazar.rudenko@gmail.com>
@gingernaz
Copy link
Contributor Author

Can we please drop this PR in favour of #315

@Belchy06 Belchy06 closed this Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

4 participants