Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Consume the context menu event instead of sending a mouse up #354

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

StomyPX
Copy link
Collaborator

@StomyPX StomyPX commented Sep 4, 2023

Relevant components:

  • Signalling server
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Right-Click dragging is presently impossible in hovering mouse mode as when the frontend receives a context menu event this gets instead sent as a right-mouse-up to Unreal Engine which is largely nonsensical.

Solution

This PR simply consumes the context menu event and allows UE to decide for itself when to open a context menu which it can already do reliably. In exchange, right-click dragging now works correctly.

Documentation

N/A

Test Plan and Compatibility

Simply launching an editor stream and testing out RMB-dragging in any viewport or node-graph shows the restored functionality.

Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Can confer will @Belchy06 on which PSInfra branches this is relevant to merge back to down to (UE 5.3 at least seems relevant).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

💚 All backports created successfully

Status Branch Result
UE5.2
UE5.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants