This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Added check if KeyboardEvent.keyCode deprecated then use KeyboardEvent.code + mapping instead. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.Code - this required a lookup table as we still send keyCode in both cases.
|
This PR addresses #46 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I "fixed" this by adding a check to see if KeyboardEvent.keyCode is not present, if so, I use KeyboardEvent.code. This change ends up sending the exact same keyCodes as before because I created a mapping from KeyboardEvent.code to KeyboardEvent.keyCode. This will mean the deprecated method will continue to be used and the codepath will be exactly the same as it has been until such a time when the browsers actually remove KeyboardEvent.keyCode and then this new code will execute.
This means no change at all on the UE side!