Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add new Common and signalling libs and rewrite Cirrus (now Wilbur) to use them #497

Merged
merged 64 commits into from
Feb 28, 2024
Merged

Add new Common and signalling libs and rewrite Cirrus (now Wilbur) to use them #497

merged 64 commits into from
Feb 28, 2024

Conversation

mcottontensor
Copy link
Contributor

  • Added Common library
  • Added Signalling library
  • Removed Cirrus
  • Added Wilbur

…ck and forth on logging. A bunch of cleanup.
…operly report the signalling version. Tweaked cli arguments.
…ence in frontend. Cleaned up some broken windows scripts for wilbur. More will need to be updated.
@mcottontensor mcottontensor changed the title New cirrus Common/Signalling/Wilbur Feb 28, 2024
@lukehb lukehb changed the title Common/Signalling/Wilbur Add new Common and signalling libs and rewrite Cirrus (now Wilbur) to use them Feb 28, 2024
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, some minor comments to address before landing.

Common/src/Protocol/SignallingProtocol.ts Outdated Show resolved Hide resolved
Frontend/implementations/typescript/webpack.common.js Outdated Show resolved Hide resolved
Matchmaker/config.json Outdated Show resolved Hide resolved
Matchmaker/matchmaker.js Outdated Show resolved Hide resolved
Signalling/README.md Outdated Show resolved Hide resolved
IF "%DEFAULT_STUN%"=="1" (
set STUN_SERVER=stun.l.google.com:19302
)
FOR /f %%A IN ('powershell -command "(Test-Connection -ComputerName (hostname) -Count 1 | Select IPV4Address).IPV4Address.IPAddressToString"') DO set LOCAL_IP=%%A
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove dep on powershell by doing? Does that work?

@Echo off
for /f "tokens=1* delims=: " %%A in (
  'nslookup myip.opendns.com. resolver1.opendns.com 2^>NUL^|find "Address:"'
) Do set ExtIP=%%B
Echo External IP is : %ExtIP%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably work something out, but we're already using powershell for the ipify remote ip lookup.

IF NOT "%TURN_USER%"=="" (
IF NOT "%TURN_PASS%"=="" (
pushd %SCRIPT_DIR%coturn\
IF "%1"=="bg" (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for bg to be in the help commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because it's not a cli option but more of an option of the function being called

@mcottontensor mcottontensor merged commit 240e712 into EpicGames:UE5.5 Feb 28, 2024
1 check passed
@mcottontensor mcottontensor deleted the new_cirrus branch February 28, 2024 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants