Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Fix controller button messages not being sent #8

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

sheepsteak
Copy link
Member

At the moment pressing and releasing gamepad buttons doesn't send any data back to UE. With this fix the messages are sent.

However, the triggers on an Xbox gamepad don't seem to work still. The messages send (and I can log them out in UE) but they don't have the same result as connecting a gamepad to UE locally.

Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For the other issue about triggers not working as expected this sounds like a UE side issue. We will open a UE jira for this internally. @Belchy06 For the UE side issue.

@lukehb lukehb merged commit 11e19a0 into EpicGames:master Jul 10, 2022
@sheepsteak sheepsteak deleted the fix-controller-buttons branch July 11, 2022 09:33
@Belchy06
Copy link
Collaborator

Hey there @sheepsteak.

I've been looking into the shoulder issue you brought up in your PR.

I'm unable to reproduce this issue using the latest version of Pixel Streaming found in UE5-Main (https://github.com/EpicGames/UnrealEngine/tree/ue5-main).

I'm not sure what version you were using, and with a refactor recently being completed on how Pixel Streaming handles input from the browser it's likely this issue was fixed then.

Let me know how you go!

@sheepsteak
Copy link
Member Author

Thanks, @Belchy06. They seem to not work in 5.0.3 and earlier. It's like it was mapped to the wrong thing (possibly right shoulder button?).

We tried ue5-main ourselves just now and it looks like it's working as expected 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants