Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Multi-streamer QOL improvements #88

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Multi-streamer QOL improvements #88

merged 8 commits into from
Feb 13, 2023

Conversation

Belchy06
Copy link
Collaborator

This PR adds a few QOL improvements to the library, specifically for the case where the are multiple streamers.

  • The streamer selector is now updated on stream start to show you which streamer has been selected
  • The PreferSFU toggle is now functional again
  • Changing the streamer selector during a stream destroys the current peer connection and connects to the newly selected streamer (UE doesn't support re-negotiation so this is currently one of the only options)
  • Auto subscription on only one streamer has moved from cirrus to the frontend (tested and maintains backwards compatability).

The frontend now has an order of operations when checking which streamer to subscribe to. It is as follows:

  • If there's a single streamer, subscribe to it regardless of what's in the URL
  • If there's an SFU AND the PreferSFU toggle is on, subscribe to it regardless of what's in the URL
  • If there's a streamer ID in the URL AND this streamer is connected to the signalling server, subscribe to it
  • If none of the above conditions are met, no stream is subscribed to

@Belchy06 Belchy06 requested a review from lukehb February 13, 2023 01:21
@Belchy06 Belchy06 self-assigned this Feb 13, 2023
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commented have be addressed. Landing.

@lukehb lukehb merged commit 4fc43bc into EpicGames:master Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants